Looks: e92 looks sooo much better than the e60 (ESPECIALLY the pre-facelift version). I personally hated the pre-facelift e60, but I love the post-facelift one, funny huh?
Performance: Don't even need to bother with this one. Agility, speed, you know the deal here.
Interior: Besides interior space, I actually think the materials are better/par with the pre-facelift e60s. Yes, they changed a lot in the facelift.
Practicality: The 5er is roomier, has a larger trunk, and is more comfy. Definitely the winner.
I'd definitely pick the 335Xi.
Past:'08 E92 335i|ZPP|ZSP|6AT|four (4) HPFPs
Present:'15 Mustang GT|401A|PP|6MT|Recaros
Sig pic unrelated. I like to go sideways and stuff.