E90Post
 


 
BMW 3-Series (E90 E92) Forum > E90 / E92 / E93 3-series Powertrain and Drivetrain Discussions > N54 Turbo Engine / Drivetrain / Exhaust Modifications - 335i > Monitoring ignition advance for all cylinders on piggybacks



Reply
 
Thread Tools Search this Thread
      08-02-2011, 03:49 PM   #45
jpsimon
Team Zissou
jpsimon's Avatar
United_States
3065
Rep
10,197
Posts

Drives: 2022 AWD M3 Comp - SMB
Join Date: Dec 2006
Location: CT

iTrader: (7)

shoulda got a 6mt myst
Appreciate 0
      08-02-2011, 03:54 PM   #46
themyst
Major General
themyst's Avatar
South Korea
177
Rep
6,631
Posts

Drives: '16 MK7 GTI
Join Date: Feb 2009
Location: NYC

iTrader: (8)

Quote:
Originally Posted by jpsimon View Post
shoulda got a 6mt myst
I had a 6MT 135i. That pathetic excuse of a notchy gearbox, bogging, etc all over again? No thanks.
__________________
E90 LCI N54 6AT
Appreciate 0
      08-02-2011, 03:55 PM   #47
jpsimon
Team Zissou
jpsimon's Avatar
United_States
3065
Rep
10,197
Posts

Drives: 2022 AWD M3 Comp - SMB
Join Date: Dec 2006
Location: CT

iTrader: (7)

driving my girlfriend's AT is so boring, i would NEVER get one
Appreciate 0
      08-02-2011, 03:56 PM   #48
dzenno
Banned
Canada
273
Rep
5,876
Posts

Drives:
Join Date: Feb 2006

iTrader: (1)

Quote:
Originally Posted by vasillalov View Post
Shiv must be diligently writing an new beta update that includes includes ignition logging for all 6 cylinders which will be in the next beta firmware. ...but not really activated in autotuning till the beta firmware after that... LOL
It'll be definitely challenging as you can't tack on too many channels on the CANBus concurrently and expect it to be reliable/fast...reading from the canbus slows down dramatically after a certain X number of channels are added for monitoring so you need to pick/choose wisely...on top of that reading from the CANBus the piggy way is currently around 10-20/sec...to use that for any sort of ignition control logic in the high RPMs would be fairly slow and with that comes reliability..

i'm all for total progress in tuning on the N54 but this one is going to be a challenge for the piggies IF they decide to go there...
Appreciate 0
      08-02-2011, 04:00 PM   #49
themyst
Major General
themyst's Avatar
South Korea
177
Rep
6,631
Posts

Drives: '16 MK7 GTI
Join Date: Feb 2009
Location: NYC

iTrader: (8)

Quote:
Originally Posted by jpsimon View Post
driving my girlfriend's AT is so boring, i would NEVER get one
I've owned so many manual cars over the past 12 years, honestly I love the auto and probably will never go back.

Owned a s2000, g35, civic si, 135i, all in manual. if you enjoy driving a manual, to each their own.
__________________
E90 LCI N54 6AT
Appreciate 0
      08-02-2011, 04:01 PM   #50
themyst
Major General
themyst's Avatar
South Korea
177
Rep
6,631
Posts

Drives: '16 MK7 GTI
Join Date: Feb 2009
Location: NYC

iTrader: (8)

Quote:
Originally Posted by dzenno View Post
It'll be definitely challenging as you can't tack on too many channels on the CANBus concurrently and expect it to be reliable/fast...reading from the canbus slows down dramatically after a certain X number of channels are added for monitoring so you need to pick/choose wisely...on top of that reading from the CANBus the piggy way is currently around 10-20/sec...to use that for any sort of ignition control logic in the high RPMs would be fairly slow and with that comes reliability..

i'm all for total progress in tuning on the N54 but this one is going to be a challenge for the piggies IF they decide to go there...
+1 you can only poll the CANbus so quickly.
__________________
E90 LCI N54 6AT
Appreciate 0
      08-02-2011, 04:04 PM   #51
vasillalov
Mad Linux Guru On The Loose
vasillalov's Avatar
1121
Rep
5,396
Posts

Drives: 2008 335i Sedan, 2023 M3
Join Date: Aug 2009
Location: Chicago, IL

iTrader: (5)

Garage List
2023 BMW M3  [0.00]
2008 335i E90  [8.00]
Quote:
Originally Posted by dzenno View Post
It'll be definitely challenging as you can't tack on too many channels on the CANBus concurrently and expect it to be reliable/fast...reading from the canbus slows down dramatically after a certain X number of channels are added for monitoring so you need to pick/choose wisely...on top of that reading from the CANBus the piggy way is currently around 10-20/sec...to use that for any sort of ignition control logic in the high RPMs would be fairly slow and with that comes reliability..

i'm all for total progress in tuning on the N54 but this one is going to be a challenge for the piggies IF they decide to go there...
I know all that buddy!

Interestingly enough, I ALSO happen to remember how last year I got both Shiv and Mike to officially state that Vishnu and BMS products pack enough processing power to handle all sensor channels at any refresh frequency they wanted. HAHAHA!
__________________
6MT | COBB | AR | AE | Forge DV | HPF | P3 Gauge | Hybrid Intake | O.S.Giken TCD | All M3 bits | TCKLine | StopTech | UUC | ER | SPEC
Appreciate 0
      08-02-2011, 04:06 PM   #52
themyst
Major General
themyst's Avatar
South Korea
177
Rep
6,631
Posts

Drives: '16 MK7 GTI
Join Date: Feb 2009
Location: NYC

iTrader: (8)

Quote:
Originally Posted by vasillalov View Post
I know all that buddy!

Interestingly enough, I ALSO happen to remember how last year I got both Shiv and Mike to officially state that Vishnu and BMS products pack enough processing power to handle all sensor channels at any refresh frequency they wanted. HAHAHA!
Yeah I guess that explains why we can only log 10 channels on the Procede software at a time. Meh
__________________
E90 LCI N54 6AT
Appreciate 0
      08-02-2011, 04:14 PM   #53
Joshboody
Lieutenant Colonel
65
Rep
1,708
Posts

Drives: pickemuptruck
Join Date: Jul 2009
Location: Phoenix, AZ

iTrader: (7)

I would love the ability to view all cylinders but more of a diagnostic. I don't think peeps are really understanding that cylinder 1 is a reference. Just like the timing map for the DME is a reference. The DME will then adjust from there dynamically, which is kept in place with the piggy of course.

More log channels added to autotune is not necessary, but for logging purpose would be great.

I wouldn't want a situation where I'm adding aggression to my tune when cylinder 6 is performing poorly... same situation as changing the Cobb ATR map.

EDIT: I guess you could autotune off the poorest cylinder... can't find a fault in that really, except for processing power.
Appreciate 0
      08-02-2011, 09:08 PM   #54
dzenno
Banned
Canada
273
Rep
5,876
Posts

Drives:
Join Date: Feb 2006

iTrader: (1)

Quote:
Originally Posted by Joshboody View Post
I would love the ability to view all cylinders but more of a diagnostic. I don't think peeps are really understanding that cylinder 1 is a reference. Just like the timing map for the DME is a reference. The DME will then adjust from there dynamically, which is kept in place with the piggy of course.

More log channels added to autotune is not necessary, but for logging purpose would be great.

I wouldn't want a situation where I'm adding aggression to my tune when cylinder 6 is performing poorly... same situation as changing the Cobb ATR map.

EDIT: I guess you could autotune off the poorest cylinder... can't find a fault in that really, except for processing power.
No doubt that logging this information is/would be beneficial to any tune...however what's more of an issue here is using CPS to control timing by applying global changes "based on" just events in one cylinder...i'm not going to pretend that I know how the DIC logic on the procede works or how autotuning works on the procede or JB4 or anything like that...i'm just bringing this to your attention and you can answer the questions and raise issues for yourself as you see fit...do you feel comfortable that there's logic in a piggy based on cylinder 1 which is then applied globally across all cylinders...my answer would be is that as long as there's no advance being added (which has been experimented with recently) that its not harmful...now given that part is out of the way I also have to say that the approach behind CPS offset is great for failsafe logic where timing needs to be globally "retarded" across all cylinders...however all the logic that sits upon is referencing just one cylinder so in my mind is not enough...

I asked Cobb if it was ok to share a log with timing corrections included and they were nice enough to let you guys see it even though this isn't yet publicly released...Attached to this post is a CSV file of a log of one of many runs I've done in the past while...this one is on pump gas no meth...it hits 17+ psi and then tapers down heavily in the upper RPMs and runs about 4 degrees less advance than the stock tune (i.e. 10.5deg at redline)

File is attached to the post..had to rename it from .csv to .txt to be able to attach...open it in Excel for easy viewing..
Attached Files
File Type: txt datalog-timing-corrections.csv.txt (7.1 KB, 110 views)
Appreciate 0
      08-02-2011, 09:23 PM   #55
vasillalov
Mad Linux Guru On The Loose
vasillalov's Avatar
1121
Rep
5,396
Posts

Drives: 2008 335i Sedan, 2023 M3
Join Date: Aug 2009
Location: Chicago, IL

iTrader: (5)

Garage List
2023 BMW M3  [0.00]
2008 335i E90  [8.00]
Dzenno,

Interesting log indeed! Couple of questions:

This is a wot pull, correct? Which gear?


Shiv,

Do you see that column that says TPS Act %? Yes, that's the one that tells you how much the throttle is open. Pay close attention to the values in that column as there are a lot of them over 78%. Didn't you claim that 78% is the MAXIMUM that the throttle plate is capable of? Hmmm... Might wanna check on that....
__________________
6MT | COBB | AR | AE | Forge DV | HPF | P3 Gauge | Hybrid Intake | O.S.Giken TCD | All M3 bits | TCKLine | StopTech | UUC | ER | SPEC
Appreciate 0
      08-02-2011, 09:24 PM   #56
mithiral67
That guy
mithiral67's Avatar
117
Rep
5,740
Posts

Drives: 2015 Cayman GTS
Join Date: Jun 2008
Location: Chicago Burbs

iTrader: (4)

Garage List
So the "CylX Timing Cor (¡)" columns notes the amount of less timing that the X cylinder is running compared to 1? Therefore at 6589 rpms, cylinder two is running 8.63 degrees timing?
Appreciate 0
      08-02-2011, 09:26 PM   #57
dzenno
Banned
Canada
273
Rep
5,876
Posts

Drives:
Join Date: Feb 2006

iTrader: (1)

Quote:
Originally Posted by vasillalov View Post
Dzenno,

Interesting log indeed! Couple of questions:

This is a wot pull, correct? Which gear?


Shiv,

Do you see that column that says TPS Act %? Yes, that's the one that tells you how much the throttle is open. Pay close attention to the values in that column as there are a lot of them over 78%. Didn't you claim that 78% is the MAXIMUM that the throttle plate is capable of? Hmmm... Might wanna check on that....
This was 3rd gear..as are 99% of the WOT pulls I do when datalogging..


Quote:
Originally Posted by mithiral67 View Post
So the "CylX Timing Cor (¡)" columns notes the amount of less timing that the X cylinder is running compared to 1? Therefore at 6589 rpms, cylinder two is running 8.63 degrees timing?
Cyl X timing Correction is how much cyl X timing curve is being corrected by..i didn't provide timing values for the rest of the cylinders...this log was to illustrate corrections across all 6 cylinders and show cyl 1 timing which is the only one monitored by piggies for a lot of their logic...

So cyl 2 timing correction is how much retard is being applied to the cyl 2 timing curve at that instant in time...in the piggy logs the Ignition Advance curve = Timing Cylinder 1 + Timing Correction Cylinder 1...correction is always a negative number or zero...
Appreciate 0
      08-02-2011, 09:31 PM   #58
vasillalov
Mad Linux Guru On The Loose
vasillalov's Avatar
1121
Rep
5,396
Posts

Drives: 2008 335i Sedan, 2023 M3
Join Date: Aug 2009
Location: Chicago, IL

iTrader: (5)

Garage List
2023 BMW M3  [0.00]
2008 335i E90  [8.00]
Quote:
Originally Posted by dzenno View Post
Cyl X timing Correction is how much cyl X timing curve is being corrected by..i didn't provide timing values for the rest of the cylinders...this log was to illustrate corrections across all 6 cylinders and show cyl 1 timing which is the only one monitored by piggies for a lot of their logic...

So cyl 2 timing correction is how much retard is being applied to the cyl 2 timing curve at that instant in time...in the piggy logs the Ignition Advance curve = Timing Cylinder 1 + Timing Correction Cylinder 1...correction is always a negative number or zero...
Bravo!

I hope people are reading this carefully!
__________________
6MT | COBB | AR | AE | Forge DV | HPF | P3 Gauge | Hybrid Intake | O.S.Giken TCD | All M3 bits | TCKLine | StopTech | UUC | ER | SPEC
Appreciate 0
      08-02-2011, 09:32 PM   #59
mithiral67
That guy
mithiral67's Avatar
117
Rep
5,740
Posts

Drives: 2015 Cayman GTS
Join Date: Jun 2008
Location: Chicago Burbs

iTrader: (4)

Garage List
Quote:
Originally Posted by dzenno View Post
Cyl X timing Correction is how much cyl X timing curve is being corrected by..i didn't provide timing values for the rest of the cylinders...this log was to illustrate corrections across all 6 cylinders and show cyl 1 timing which is the only one monitored by piggies for a lot of their logic...

So cyl 2 timing correction is how much retard is being applied to the cyl 2 timing curve at that instant in time...in the piggy logs the Ignition Advance curve = Timing Cylinder 1 + Timing Correction Cylinder 1...correction is always a negative number or zero...
I apologize for the slow uptake on my part. I might be confused by your comments as I dont fully understand how timing correction works across cylinders. I really only understand how its controlled/modified on a single cylinder basis.

Can you calculate the actual degree of timing on each of the cylinders (other than 1 as its provided) from the logs provided?
Appreciate 0
      08-02-2011, 09:38 PM   #60
dzenno
Banned
Canada
273
Rep
5,876
Posts

Drives:
Join Date: Feb 2006

iTrader: (1)

Quote:
Originally Posted by mithiral67 View Post
I apologize for the slow uptake on my part. Can you calculate the actual degree of timing on each of the cylinders (other than 1 as its provided) from the logs provided?
No need to calculate anything...cyl 1 timing in the log takes into account the correction....i can run a log with all cylinder timing values and all cylinder timing corrections in one and show it to you guys but it'll have to wait until tomorrow..

Look at it like this:

Actual (Current) Timing on Cylinder X = DME Requested Timing Curve + Timing Correction on Cylinder X

Timing correction is dynamic and can change an ANY time given octane/conditions. DME Requested Timing Curve is what a flash is setup with to run when conditions are optimal (best octane + best conditions). The Actual Timing on a given cylinder X is the value you get once you subtract timing correction from the DME Requested Timing Curve which has been flashed to the DME for that particular map or as Cobb calls it "calibration".
Appreciate 0
      08-02-2011, 09:46 PM   #61
cstmx_ryder
Colonel
cstmx_ryder's Avatar
United_States
164
Rep
2,875
Posts

Drives: A metal box with a roundel
Join Date: Jul 2007
Location: Portland, OR

iTrader: (2)

dzenno,

I can't read the log you posted. I have a Mac......

Is there anyway you can repost so that I can see?

TIA
__________________

'08 AW E90 335i
PROcede V5 | BMS DCI | RR DPs | ETS FMIC | FORGE DVs | Stett CP | Vanguard | PSS10
Appreciate 0
      08-02-2011, 09:47 PM   #62
mithiral67
That guy
mithiral67's Avatar
117
Rep
5,740
Posts

Drives: 2015 Cayman GTS
Join Date: Jun 2008
Location: Chicago Burbs

iTrader: (4)

Garage List
Ok, that makes sense. I see how seeing the deta from the DME Requested Timing Curve is more informative than seeing the timing of each cylinder when it comes to monitoring for safety/performance.
Appreciate 0
      08-02-2011, 09:47 PM   #63
vasillalov
Mad Linux Guru On The Loose
vasillalov's Avatar
1121
Rep
5,396
Posts

Drives: 2008 335i Sedan, 2023 M3
Join Date: Aug 2009
Location: Chicago, IL

iTrader: (5)

Garage List
2023 BMW M3  [0.00]
2008 335i E90  [8.00]
Quote:
Originally Posted by cstmx_ryder View Post
I can't read the log you posted. I have a Mac......

TIA
HAHAHA!

I got you covered. Here is the an image of dzenno's log showing all 6 cyl with respect to boost

__________________
6MT | COBB | AR | AE | Forge DV | HPF | P3 Gauge | Hybrid Intake | O.S.Giken TCD | All M3 bits | TCKLine | StopTech | UUC | ER | SPEC
Appreciate 0
      08-02-2011, 09:48 PM   #64
dzenno
Banned
Canada
273
Rep
5,876
Posts

Drives:
Join Date: Feb 2006

iTrader: (1)

Quote:
Originally Posted by cstmx_ryder View Post
dzenno,

I can't read the log you posted. I have a Mac......

Is there anyway you can repost so that I can see?

TIA
Its a .txt file, you should be able to see it...i tried graphing it but don't have time to do it enough justice...
Appreciate 0
      08-02-2011, 09:49 PM   #65
dzenno
Banned
Canada
273
Rep
5,876
Posts

Drives:
Join Date: Feb 2006

iTrader: (1)

Quote:
Originally Posted by cstmx_ryder View Post
dzenno,

I can't read the log you posted. I have a Mac......

Is there anyway you can repost so that I can see?

TIA
Quote:
Originally Posted by vasillalov View Post
HAHAHA!

I got you covered. Here is the an image of dzenno's log showing all 6 cyl with respect to boost
You're fast!
Appreciate 0
      08-02-2011, 09:49 PM   #66
onesuperboi
Major
onesuperboi's Avatar
United_States
52
Rep
1,357
Posts

Drives: '08 e92 335i COBB 4.01 Stage 1
Join Date: Aug 2008
Location: Bay Area, CA (Alameda)

iTrader: (6)

Quote:
Originally Posted by vasillalov View Post
HAHAHA!

I got you covered. Here is the an image of dzenno's log showing all 6 cyl with respect to boost

You sure that is all six!
Appreciate 0
Reply

Bookmarks


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off



All times are GMT -5. The time now is 01:52 AM.




e90post
Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.
1Addicts.com, BIMMERPOST.com, E90Post.com, F30Post.com, M3Post.com, ZPost.com, 5Post.com, 6Post.com, 7Post.com, XBimmers.com logo and trademark are properties of BIMMERPOST